-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(isMobilePhone): Added regex for Aruba nl-AW #1985
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1985 /- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 103 103
Lines 2099 2099
Branches 474 474
=========================================
Hits 2099 2099
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM @profnandaa
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
Thank you for your PR @adida948
@rubiin -- you'd an invite to join the org, let me resend. Thanks for your review on this too! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just the m/c which I'll fix on a bulk PR before release.
HI, let me know if there is anything else needed from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On Readme there is still the merge markers. please remove that
@rubiin tried the github UI. I messed up the update. Did it from command line now. |
Added validation for Aruba on isMobilePhone.
referred issue: #1761
Checklist