Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(isLicensePlate): hu-HU locale #1895

Closed
wants to merge 5 commits into from

Conversation

szabolcstarnai
Copy link
Contributor

@szabolcstarnai szabolcstarnai commented Jan 17, 2022

Added Hungarian locale for license plates

info: https://hu.wikipedia.org/wiki/Magyar_forgalmi_rendszámok

Checklist

  • PR contains only changes related; no stray files, etc.
  • README updated (where applicable)
  • Tests written (where applicable)

@codecov
Copy link

codecov bot commented Jan 17, 2022

Codecov Report

Merging #1895 (76403fe) into master (c1b21a9) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master     #1895    /-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          102       102           
  Lines         2085      2086     1     
  Branches       472       472           
=========================================
  Hits          2085      2086     1     
Impacted Files Coverage Δ
src/lib/isLicensePlate.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1b21a9...76403fe. Read the comment docs.

rubiin
rubiin previously approved these changes Feb 14, 2022
Copy link
Member

@rubiin rubiin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Copy link
Member

@profnandaa profnandaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest looks good, just the m/c. Thanks for your contrib 🎉

@@ -140,7 140,11 @@ Validator | Description
**isJWT(str)** | check if the string is valid JWT token.
**isLatLong(str [, options])** | check if the string is a valid latitude-longitude coordinate in the format `lat,long` or `lat, long`.<br/><br/>`options` is an object that defaults to `{ checkDMS: false }`. Pass `checkDMS` as `true` to validate DMS(degrees, minutes, and seconds) latitude-longitude format.
**isLength(str [, options])** | check if the string's length falls in a range.<br/><br/>`options` is an object which defaults to `{min:0, max: undefined}`. Note: this function takes into account surrogate pairs.
<<<<<<< HEAD
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the merge conflict please...

@profnandaa profnandaa added mc-to-land Just merge-conflict standing between the PR and landing. 🧹 needs-update For PRs that need to be updated before landing labels Apr 22, 2022
profnandaa added a commit that referenced this pull request Jan 31, 2023
chore: clean up PR #1895 
---------

Co-authored-by: szabolcstarnai <[email protected]>
@profnandaa
Copy link
Member

combined in #2164

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
mc-to-land Just merge-conflict standing between the PR and landing. 🧹 needs-update For PRs that need to be updated before landing PR/combined
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants