-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(niceToHave): Export list of country codes that implement IBAN #1669
feat(niceToHave): Export list of country codes that implement IBAN #1669
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1669 /- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 101 101
Lines 1854 1855 1
=========================================
Hits 1854 1855 1
Continue to review full report at Codecov.
|
Co-authored-by: Federico Ciardi <[email protected]>
src/index.js
Outdated
@@ -48,7 48,7 @@ import isHSL from './lib/isHSL'; | |||
|
|||
import isISRC from './lib/isISRC'; | |||
|
|||
import isIBAN from './lib/isIBAN'; | |||
import isIBAN, { locales as isIBANLocales } from './lib/isIBAN'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
May be calling them isIBANLocales
could be a little misleading, might think it's a validator/function. Perhaps just drop the is
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@profnandaa I see what you're saying, but I think it's more inline with the rest of the code to call it isIBANLocales
Check also the failing tests. |
@profnandaa pushed test fixes, could you please approve running the workflow? |
Hi @fedeci :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but I also agree with this comment
@@ -5,6 5,7 @@ import { locales as isAlphaLocales } from '../src/lib/isAlpha'; | |||
import { locales as isAlphanumericLocales } from '../src/lib/isAlphanumeric'; | |||
import { locales as isMobilePhoneLocales } from '../src/lib/isMobilePhone'; | |||
import { locales as isFloatLocales } from '../src/lib/isFloat'; | |||
import { locales as ibanCountryCodes } from '../src/lib/isIBAN'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
import { locales as ibanCountryCodes } from '../src/lib/isIBAN'; | |
import { locales as isIBANLocales } from '../src/lib/isIBAN'; |
I would name it isIBANLocales
to align to the other one.
@fedeci got you, just made the change |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution.
NP! thanks for your help :) |
Export a list of country codes implementing IBAN
Addressing issue #1570
Checklist