add(isURL): added validate_length option #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix for issue: #1396
profnandaa
approved these changes
Jul 29, 2020
There was a problem hiding this comment.
LGTM, thanks for your contrib! 🎉
@tux-tn -- could you have a second look on this?
tux-tn
requested changes
Jul 29, 2020
There was a problem hiding this comment.
@tomgrossman Thank you for your contribution 🎉
lib folder is generated by babel, you need to make your changes inside src/lib folder. In addition, you'll have to update existing tests (there is a test case where the URL is longer than 2083) and add new tests for your added option
|
@tux-tn fixed. for some reason I can't click on the "re-request review" button, it doesn't work... |
profnandaa
approved these changes
Aug 1, 2020
|
Opened related issue: #1412 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue: #1396
Today the
isURLfunction validate hard-coded for max 2083 string length. This is not part of the RFC and should be able to skip this validation.Checklist