-
-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output terminal isn't cleared when second to last frame is taller than terminal #585
Labels
Comments
matteodepalo
changed the title
Output terminal isn't cleared on exit when second to last frame is taller than terminal
Output terminal isn't cleared when second to last frame is taller than terminal
May 3, 2023
After creating this issue I noticed that this doesn't happen just on exit, it happens even without it. I've updated the issue. |
Thanks for a detailed bug report! Submitted a fix over here → #586. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Hi,
As per description, I noticed that the terminal is correctly cleared if the last frame output is taller than the terminal window, however, if the last frame is shorter, the second to last frame isn't cleared. Here's a video to demonstrate this:
03-50-xck1w-29hr6.mp4
I would expect ink to not show the list after pressing enter. Is this expected behavior?
For now I've littered my code with things like this, but I would expect Ink to handle such scenarios.
Where
wrapperHeight
is the height of theBox
containing everything.Code to reproduce (make your terminal window height less than 20 lines):
Reproduction repo https://github.com/matteodepalo/clear-terminal
The text was updated successfully, but these errors were encountered: