Release 2.5.1 #3336
Merged
Release 2.5.1 #3336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sync develop with 2.5.0
`gulp regression` task was failing to start up chromeFractalTester.
…nto jm-disable-forceMediaMerge
[USWDS] - [gulp sass] Disable forceMediaMerge in CSSO.
Update references to 2.5.1
mejiaj
approved these changes
Mar 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Site Preview TK →
Library Preview →
Removed media query sorting. CSSO's
forceMediaMergewasn't exporting media queries in the expected order, so we're disabling it for more reliable CSS output. While both the minified and unminified CSS files are modestly larger as a result:268 KBunsorted vs.259 KBsorted, our testing indicates that once the files are compressed server side with gzip, the unsorted CSS is actually smaller:36 KBunsorted and gzipped vs.38 KBsorted and gzipped. As a result, we recommend that teams do not use media query sorting at this time.Note: This release also temporarily removes the best practice tests from our aXe testing until we can reinstate these tests as warnings rather than errors (#3333). This aXe change should come in the next minor version this month (
2.6.0).Package updates
Audit
found 7 vulnerabilities (5 low, 2 high)