Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.5.0 #3319

Merged
merged 110 commits into from
Feb 14, 2020
Merged

Release 2.5.0 #3319

merged 110 commits into from
Feb 14, 2020

Conversation

thisisdano
Copy link
Member

@thisisdano thisisdano commented Feb 13, 2020

Preview 🎉

What's new in USWDS 2.5.0

⚠️ Improved component accessibility and testing. We upgraded our accessibility testing with aXe from 2.6.1 to 3.4.1 and improved the accessibility of our markup in the process. This introduces minor changes to the markup of 5 components and our documentation template — you should update your markup, but existing markup will not break:

  • banner: is now a <section> instead of a <div> with the ARIA label Official government website
  • footer: nav includes the ARIA label of Footer navigation
  • graphic-list: uses h2 as a heading default instead of h3
  • hero: includes the ARIA label of Introduction
  • search: the search form is given the ARIA role of search
  • documentation template: includes only the main content in the <main> element. The nav is no longer treated as an <aside>

PR: #3280

Allow non-token values in state color settings. Now state tokens (like "warning") can accept non-token colors, just as we introduced for theme colors in 2.4.0. Teams using non-token values can now keep colors consistent between theme and state. Using non-token values will throw a warning in the compile process, but this, like all compile warnings, can be disabled by setting $theme-show-compile-warnings: false. Thanks @sawyerh! #3289

Updated to the canonical Sass compiler. We're now using Dart Sass to compile the system Sass. Dart Sass is the canonical Sass compiler, so using it will keep us at feature parity and help prevent inadvertent inconsistencies. #3304

Output utility classes in proper order without media query sorting. We no longer require media query sorting for proper utility class output. We no longer use a dedicated media query sorter in our dependencies, and do all our optimization with csso (deprecating cssnano). #3308

Improved performance. We've improved the time it takes to compile the design system and its overall file size:

version build:sass gulp sass unminified minified
2.4.0 14s 6.5s 359 KB 270 KB
2.5.0 7.5s 5.2s 357 KB 259 KB

Allows USWDS notifications to render in all environments. We removed the multiline strings that were causing our notification to cause build failures in environments like webpack. Now the Sass should compile properly in all environments. #3290

Update to the most recent version of Public Sans. Updated to Public Sans 1.008 for better readability and display. #3275

Added missing add-aspect() mixin. This adds the mixin equivalent to the add-aspect utility classes. #3283

Improved error messaging for the lh() function. Now it lets you know why it failed and how to fix the error. #3284

Disabled JS in our Fractal library to remediate an out-of-date jQuery vulnerability. #3274

Package updates:

package old new
@types/node 12.12.20 13.5.0
axe-core 2.6.1 3.4.1
cssnano deprecated
css-mqpacker deprecated
gulp-spawn-mocha 5.0.1 6.0.0
jsdom 9.0.0 16.0.1
jsdom-global 2.1.0 3.0.2
mocha 5.2.0 7.0.1
nyc 14.1.1 15.0.0
postcss-csso 4.0.0
sass 1.25.0

7 vulnerabilities (5 low, 2 high) in 29833 scanned packages All but one low vulnerability are related to Fractal.

mejiaj and others added 30 commits December 18, 2019 16:55
Remove mandelbrot scripts to remove jquery vuln
Github Repo - README.md: fix file extension typo
[UI component]: Remove additional positioning rules on banner close button
Divs were causing it to be detected as a top-level document header.
This conflicted with other top-level header used for nav.
- Add headings and references to graphic-list component
- Add header and reference to hero component
- Move search components into their own section element w/ references
- Add aria-label to footer nav
- Change aside → div in kitchen sink example
- Fix ESLint errors axe-tester, chrome-fractal-tester, and headless-chrome
Combination issue. Tables were causing scroll and body wasn't reachable
by tab. Fixed issue by adding `tabindex="0"` to body.
Watch task was copying same file on compile every time it was run.
Gulp-changed runs it once and then doesn't touch it unless it's changed.
@thisisdano thisisdano mentioned this pull request Feb 13, 2020
@thisisdano
Copy link
Member Author

Please hold — I found a typo I need to correct.

Copy link
Contributor

@mejiaj mejiaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The order of docs-inner.njk might need another look. Otherwise 👍

src/components/layouts/docs-inner.njk Outdated Show resolved Hide resolved
@mejiaj
Copy link
Contributor

mejiaj commented Feb 13, 2020

image

I think there's a regression in the icons.

@thisisdano
Copy link
Member Author

Did another component spot check and didn't see anything

@thisisdano thisisdano merged commit 216e186 into master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants