Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ARIA role to footer navigation #3318

Merged
merged 3 commits into from
Feb 13, 2020
Merged

Add ARIA role to footer navigation #3318

merged 3 commits into from
Feb 13, 2020

Conversation

thisisdano
Copy link
Member

  • Adds aria-label="Footer navigation" to the footer nav

Fixes #3314

@thisisdano thisisdano added this to the February 2020 Monthly Call milestone Feb 13, 2020
@thisisdano thisisdano self-assigned this Feb 13, 2020
@thisisdano thisisdano added this to Review in USWDS Sprint Board via automation Feb 13, 2020
@mejiaj mejiaj merged commit 50234f1 into develop Feb 13, 2020
USWDS Sprint Board automation moved this from Review to Done Feb 13, 2020
@mejiaj mejiaj deleted the dw-add-footer-nav-aria branch February 13, 2020 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mejiaj mejiaj mejiaj approved these changes

Assignees

@thisisdano thisisdano

Labels
Package: Footer
Projects
USWDS Sprint Board
  
Done
Milestone
February 2020 Monthly Call
Development

Successfully merging this pull request may close these issues.

Footer nav needs a distinguishing label
2 participants
@thisisdano @mejiaj