Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: a number of issues with cannon settings handling #1315

Merged
merged 3 commits into from
Aug 26, 2024
Merged

fix: a number of issues with cannon settings handling #1315

merged 3 commits into from
Aug 26, 2024

Conversation

dbeal-eth
Copy link
Contributor

  • fix settings to be able to load registry settings from file successfully
  • add tests to verify that file settings, env settings, and their interplay work as expected
  • updates the builder constants to use our own infura service (the infura is gated to only accept requests relating to our registry contracts and no others)

@dbeal-eth
fix a number of issues with cannon settings handling:
de2cd95 
* fix settings to be able to load registry settings from file successfully
* add tests to verify that file settings, env settings, and their interplay work as expected
* updates the builder constants to use our own infura service (the infura is gated to only accept requests relating to our registry contracts and no others)
@dbeal-eth dbeal-eth added the bug Something isn't working label Aug 26, 2024
@dbeal-eth dbeal-eth self-assigned this Aug 26, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 26, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 9bf79b9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dbeal-eth dbeal-eth changed the title fix a number of issues with cannon settings handling: fix: a number of issues with cannon settings handling: Aug 26, 2024
@dbeal-eth dbeal-eth changed the title fix: a number of issues with cannon settings handling: fix: a number of issues with cannon settings handling Aug 26, 2024
@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Aug 26, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 9bf79b9. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@dbeal-eth dbeal-eth merged commit d679f87 into main Aug 26, 2024
6 of 9 checks passed
@dbeal-eth dbeal-eth deleted the fix-settings-again branch August 26, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noahlitvin noahlitvin noahlitvin approved these changes

@saeta-eth saeta-eth saeta-eth approved these changes

Assignees

@dbeal-eth dbeal-eth

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dbeal-eth @noahlitvin @saeta-eth