fix(website): Use Ipfs reference for partial deploy on web #1305
Conversation
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit b6cdcfe. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
FuzzB0t
changed the title
| @@ -414,7 414,13 @@ const commandsConfig = { | |||
| description: 'IPFS hash to write deployment data for', | |||
| }, | |||
| ], | |||
| options: [...debugVerbosity], | |||
| options: [ | |||
There was a problem hiding this comment.
Added chain id option to pin command because the pin command fails when trying to pin a package that was built on a live network
| @@ -490,7 486,7 @@ function QueueFromGitOps() { | |||
| function renderCannonfileInput() { | |||
| return ( | |||
| <FormControl mb="4"> | |||
| <FormLabel>Cannonfile</FormLabel> | |||
| <FormLabel>Cannonfile {selectedDeployType == '3' ? '(Optional)' : ''}</FormLabel> | |||
There was a problem hiding this comment.
I know this is not part of this PR, but if we could give semantical names to '1' '2' '2' would be great.
mjlescano
force-pushed
the
partial-deploy-web
branch
from
7619f66
to
63f1ff6
Compare
I disabled the cannonfile input when a partial deployment hash hasnt been provided |
|
When landing for the first time on the gitops deployment page, directly from the link or navigating, there's no radio button selected by default, when the first one should be selected: |
fixes https://linear.app/usecannon/issue/CAN-444/add-deployments-from-partial-deploy-file
This ticket redesigns the deploy page and removes the need to specify cannonfile url in partial deployments on the web app.
Below is an example of running a partial deployment (I ran the same thing on the current instance of the website and confirmed the error response was the same on there)
Without cannonfile ref:
https://www.loom.com/share/054e6dda24aa47aebd4f0c729ed83f61
With cannonfile ref:
https://www.loom.com/share/aa0414806f364c679e8b9978525cb5aa
Also added the ability to specify chain id on pin command since it was not pinning partial deployment hashes on other networks