Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alter): update contract address on subpackages #1253

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

mjlescano
Copy link
Member

@mjlescano mjlescano commented Aug 12, 2024

Closes https://linear.app/usecannon/issue/CAN-440/cannon-alter-packagename-set-contract-address-chain-id-xx-subpkg

This PR was used to debug the set-contract-address cannon command when editing subpackages.

  1. It adds the --no-publish flag to be able to test out new ipfs builds without having to publish to the registry
  2. Rewrites the set-contract-address to make it more readable and make sure that only finds 1 step by the given name
  3. Adds params validations in case of missing commands and some extra debug statements.

Copy link

changeset-bot bot commented Aug 12, 2024

⚠️ No Changeset found

Latest commit: 0a6c922

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

nx-cloud bot commented Aug 12, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 0a6c922. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

Copy link
Contributor

@dbeal-eth dbeal-eth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add tests

packages/cli/src/commands/alter.ts Outdated Show resolved Hide resolved
packages/cli/src/commands/alter.ts Outdated Show resolved Hide resolved
packages/cli/src/commandsConfig.ts Outdated Show resolved Hide resolved
@mjlescano mjlescano merged commit cffbe41 into main Aug 14, 2024
6 of 10 checks passed
@mjlescano mjlescano deleted the fix-alter-address branch August 14, 2024 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants