Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(website): Normalize empty strings inside array for contract calls #1188

Merged
merged 4 commits into from
Jul 11, 2024
Merged

fix(website): Normalize empty strings inside array for contract calls #1188

merged 4 commits into from
Jul 11, 2024

Conversation

FuzzB0t
Copy link
Contributor

@FuzzB0t FuzzB0t commented Jul 5, 2024 •
edited
Loading

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 5, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: dd817d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jul 5, 2024 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit dd817d6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution

✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@FuzzB0t FuzzB0t requested a review from a team July 5, 2024 19:09
@mjlescano mjlescano self-requested a review July 8, 2024 13:06
@dbeal-eth
Copy link
Contributor

@FuzzB0t can you send a picture/short gif/video of the working solution to confirm how it looks?

@FuzzB0t
Copy link
Contributor Author

FuzzB0t commented Jul 9, 2024 •
edited
Loading

@FuzzB0t can you send a picture/short gif/video of the working solution to confirm how it looks?

Before the error happened during encodeFunctionData:
image

After:

image

@dbeal-eth dbeal-eth merged commit f0cbc74 into main Jul 11, 2024
9 checks passed
@dbeal-eth dbeal-eth deleted the interact-empty-params branch July 11, 2024 05:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjlescano mjlescano mjlescano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FuzzB0t @dbeal-eth @mjlescano