Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Typescript #2677

Open
1 task done
sfreeman422 opened this issue Jul 21, 2024 · 3 comments
Open
1 task done

Use Typescript #2677

sfreeman422 opened this issue Jul 21, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@sfreeman422
Copy link
Contributor

I have checked the following:

  • I've searched existing issues and found nothing related to my issue.

Describe the feature you want to add

Proposing that this project migrate to use Typescript. Understand this is no small feat but feel it would improve the robustness of the code and prevent runtime errors from occurring and type-related bugs from making their way into the codebase. Perhaps a strategy in which specific packages within the app are chosen to include/migrate to Typescript and PRs are carefully reviewed by core maintainers, with the goal of converting the entire project to Typescript as a longer term goal.

I am curious if there are any reasons not to use Typescript that perhaps I am not considering. It seems like it would provide a lot of benefits to the project in terms of ruling out runtime errors due to bad type assumptions/null checks/etc at the cost an additional transpilation/build step.

Mockups or Images of the feature

N/A - Discussion/high level suggestion meant to engage the team/community about pros and cons surrounding a migration of this type.
@sfreeman422 sfreeman422 added the enhancement New feature or request label Jul 21, 2024
@Its-treason
Copy link
Member

Its-treason commented Jul 21, 2024 •
edited
Loading

There was a discussion opened about this almost a year ago: #555 but I think Anoop said some time ago, that the migration to typescript will move to a later date because of the Golden edition.

I forked Bruno in April and started rewriting it in typescript: https://github.com/its-treason/bruno. TypeScript usage is increased from 3% to 22% on my fork.

@sfreeman422
Copy link
Contributor Author

Awesome! Is the intent for your PR to handle the entire repo or simply specific packages one at a time?

@Its-treason
Copy link
Member

Awesome! Is the intent for your PR to handle the entire repo or simply specific packages one at a time?

A PR with the TS-Code might never happen. My fork started because I needed more features in Bruno and did want to wait for everything to get approved and merged. I already opened a good amount of PR with some still open: https://github.com/usebruno/bruno/pulls?q=is:pr author:its-treason

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sfreeman422 @Its-treason