Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat:(issue_1958) Add support for multiple layouts to TimestampFlag #1959

Merged
merged 19 commits into from
Aug 11, 2024
Merged

Feat:(issue_1958) Add support for multiple layouts to TimestampFlag #1959

merged 19 commits into from
Aug 11, 2024

Conversation

horockey
Copy link
Contributor

@horockey horockey commented Aug 6, 2024

Resolves issue 1958

@horockey horockey requested a review from a team as a code owner August 6, 2024 14:41
bartekpacia
bartekpacia reviewed Aug 6, 2024
View reviewed changes
makeout.txt Outdated Show resolved Hide resolved
Juneezee
Juneezee reviewed Aug 7, 2024
View reviewed changes
Copy link
Member

@Juneezee Juneezee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your PR!

Awaiting for more maintainers feedback

flag_test.go Outdated Show resolved Hide resolved
dearchap
dearchap reviewed Aug 8, 2024
View reviewed changes
flag_timestamp.go Outdated Show resolved Hide resolved
dearchap
dearchap reviewed Aug 8, 2024
View reviewed changes
flag_timestamp.go Outdated Show resolved Hide resolved
bartekpacia
bartekpacia reviewed Aug 9, 2024
View reviewed changes
flag_timestamp.go Outdated Show resolved Hide resolved
@dearchap dearchap changed the title Issue 1958 Feat:(issue_1958) Add support for multiple layouts to TimestampFlag Aug 10, 2024
dearchap
dearchap approved these changes Aug 10, 2024
View reviewed changes
Copy link
Contributor

@dearchap dearchap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @horockey

@dearchap dearchap merged commit fc07a8c into urfave:main Aug 11, 2024
13 checks passed
@horockey horockey deleted the issue_1958 branch August 12, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Juneezee Juneezee Juneezee left review comments

@bartekpacia bartekpacia bartekpacia left review comments

@dearchap dearchap dearchap approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple available formats for timestamp flag
4 participants
@horockey @dearchap @Juneezee @bartekpacia