Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ames: ignore message-num.task for %drop tasks #6996

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

Commits on May 22, 2024

  1. ames: ignore message-num.task for %drop tasks

    when a message in nacked (e.g. 25), we add it to
    nax.sink and create a %naxplanation message
    (e.g. 1; first ever naxplanation sent) that contains the
    nacked sequence number (25), and send it to the
    original sender on the naxplanation flow.
    
    when the ack for the naxplanation (1) comes back, we
    know that this was an ack for a naxplanation bone
    and then drop the sequence number of _this_
    naxplanation message (1) instead of the original
    message (25) that was nacked.
    
    this causes a range messages in nax.sink
    that will remain there until naxplanations catch
    up with the actual message numbers from the
    reference flow.
    
    we are removing messages that might not have been
    nacked, but that seems ok since the message won't be
    there anyway.
    
    (note: wip, currently does not work)
    yosoyubik committed May 22, 2024
    Configuration menu
    Copy the full SHA
    c15ed8f View commit details
    Browse the repository at this point in the history
  2. ames: wip sigpam prints

    yosoyubik committed May 22, 2024
    Configuration menu
    Copy the full SHA
    05e1da9 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2024

  1. Configuration menu
    Copy the full SHA
    5c0b9d3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    3b449ff View commit details
    Browse the repository at this point in the history
  3. Revert "ames: wip sigpam prints"

    This reverts commit 05e1da9.
    yosoyubik committed May 23, 2024
    Configuration menu
    Copy the full SHA
    622d47a View commit details
    Browse the repository at this point in the history