-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lagoon IEEE 754 floats #6971
Open
sigilante
wants to merge
67
commits into
next/kelvin/410
Choose a base branch
from
sigilante/lagoon-reals
base: next/kelvin/410
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Lagoon IEEE 754 floats #6971
10,788
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds a new endpoint to the verb wrapper library that gives more detail about events happening to agents. This includes sequence numbers, timestamps, source ship, mug hashes for incoming data, and a summary of the resulting effects.
A utility agent that can be told to watch agents. Doing so will make it subscribe to that agent's "verb plus" events. Verb-logger buffers those, and flushes them to unix disk in a json format periodically. Tools for viewing these logs still in development...
Include the mug for poke data, mark for facts, separate out the on-agent sign explicitly.
Using the timestamp of the first event, instead of the start of the time block. Also narrow the time block down from a day to an hour, for faster log writes. Further experimentation needed here.
Needs usability improvements for event details, range selection, among other things.
And lets you click events to make their details sticky. Also improves date rendering in some places.
Also prefixes marks with %, mugs with 0x, always.
Forget flavor-of-the-month, gulp expired _years_ ago.
New verb watching button added next to the existing one. Instead of rendering logs to text in the apps view, adds events into the logs view.
Lossy, but if the original ms timestamp came out of an urbit, it was already lossy anyway.
It doesn't contain anything by default, so is easier to scroll past/doesn't need to be collapsed to get to the verb buttons.
Not sure why this one was added in.
This reverts commit 198fa38.
in the thread-calling http interface. Specifying a content-type header of application/x-urb-jam will make the request body be interpreted as a uw-encoded jammed noun, rather than json. Specifying an accept header of application/x-urb-jam will make the thread result in the response body be rendered as a uw-encoded jammed noun, rather than json. For the latter, the output mark becomes unused, since we can just "render" the resulting noun directly, without needing to explicitly convert it. (This assumes that converting any mark to %noun will always result in the same noun, which isn't guaranteed in theory, but is always the case in practice.) This prepares spider for use in a nouns-based version of js-http-api.
This brings it in line with the serialization found in /mar/noun. The `@uw`-encoding was carried over from Eyre, who uses it for channels. In that context, outgoing jam bytes must be encoded, because newline characters (`0a` bytes) would break up the SSE data field. Because they're essentially part of the same protocol, Eyre mirrors this for incoming nouns. Even though PUT requests can carry arbitrary bytes just fine, the symmetry and protocol-wide consistency seems important. Here, we are dealing strictly with plain HTTP requests, and strictly with requests that have indicated support for the `application/x-urb-jam` mime type to boot. We should have no qualms about raw jam bytes. They're more compact/efficient, too.
Tests fixed. |
AFAICT nothing to do with Lagoon. |
Thanks. Guess things are getting moved around.
|
|
This is ready for review. |
When the tests pass here on that last commit, then this is ready to merge. @joemfb @pkova @belisarius222 @jalehman |
For posterity, the original PR (prior to refactoring several times) was #3536. |
|
Looks like the failure has nothing to do with Lagoon tests which all passed. |
cc @pkova Kiitos. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pursuant to draft UIP at https://github.com/urbit/UIPs/blob/sigilante/lagoon-reals/UIPS.
Should be released alongside corresponding Vere code.