Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ames: remove space leak for outbound naxplanations #6642

Merged
merged 9 commits into from
Jun 30, 2023
Merged

ames: remove space leak for outbound naxplanations #6642

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift click to select a range
65b83a3
Merge branch 'develop' into yu/remove-num-live
yosoyubik Jun 5, 2023
2c854d1
ames: remove space leak for outbound naxplanations
yosoyubik Jun 5, 2023
405f3d2
Merge branch 'next/kelvin/412' into yu/fix-drop-nack-state
yosoyubik Jun 8, 2023
4ee80e4
Merge branch 'next/kelvin/412' into yu/fix-drop-nack-state
yosoyubik Jun 15, 2023
f0c0288
Merge branch 'develop' into yu/fix-drop-nack-state
yosoyubik Jun 16, 2023
a20a2ff
Merge branch 'next/kelvin/412' into yu/fix-drop-nack-state
yosoyubik Jun 28, 2023
5fd372d
ames: don't crash if flow for a target bone is ~
yosoyubik Jun 29, 2023
f890453
Merge branch 'next/kelvin/412' into yu/fix-drop-nack-state
yosoyubik Jun 30, 2023
3b9a22b
Merge branch 'next/kelvin/412' into yu/fix-drop-nack-state
yosoyubik Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
58 changes: 41 additions & 17 deletions pkg/arvo/sys/vane/ames.hoon
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5043,35 5043,59 @@
::
state-15-to-16
|= old=ames-state-15
|^ ^- ^ames-state
^- ^ames-state
%= old
peers
%- ~(run by peers.old)
|= ship-state=ship-state-15
^- ^ship-state
?. ?=(%known -.ship-state)
ship-state
|^
%= ship-state
snd (~(run by snd.ship-state) message-pump-15-to-16)
keens (~(run by keens.ship-state) keen-state-15-to-16)
rcv (~(rut by rcv.ship-state) remove-outbound-naxplanations)
==
::
message-pump-15-to-16
|= pump=message-pump-state-15
^- message-pump-state
%= pump
metrics.packet-pump-state
[rto rtt rttvar ssthresh cwnd counter]:metrics.packet-pump-state.pump
==
::
keen-state-15-to-16
|= keen-state=keen-state-15
^- ^keen-state
%= keen-state
metrics [rto rtt rttvar ssthresh cwnd counter]:metrics.keen-state
==
::
remove-outbound-naxplanations
|= [=bone sink=message-sink-state]
^ sink
=/ target=^bone (mix 0b10 bone)
?. =(%3 (mod target 4))
sink
?~ pump=(~(get by snd.ship-state) target)
sink
%_ sink
nax
%- ~(rep in nax.sink)
|= [=message-num nax=(set message-num)]
:: we keep messages in the queue that have not been acked.
:: if the message-num for the naxplanation we sent is
:: less than the current message, pump-done:mu had been called,
:: so the message-num can be safely removed
::
=? nax (gte message-num current.u.pump)
(~(put in nax) message-num)
nax
==
--
==
::
message-pump-15-to-16
|= pump=message-pump-state-15
^- message-pump-state
%= pump
metrics.packet-pump-state
[rto rtt rttvar ssthresh cwnd counter]:metrics.packet-pump-state.pump
==
::
keen-state-15-to-16
|= keen-state=keen-state-15
^- ^keen-state
%= keen-state
metrics [rto rtt rttvar ssthresh cwnd counter]:metrics.keen-state
==
--
--
:: scry: dereference namespace
::
Expand Down