Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add removeAllHooks utility #61

Merged
merged 3 commits into from
Mar 10, 2023
Merged

feat: add removeAllHooks utility #61

merged 3 commits into from
Mar 10, 2023

Conversation

nozomuikuta
Copy link
Member

Resolves #52.

As far as I see the code, there is no (instant) way to achieve @tmkx"s goal.
So, I dded a utility function for such purpose.

⚠️ This is my very first PR to this repository, so I might be missing something important. 🙏

@nozomuikuta nozomuikuta requested review from pi0 and danielroe December 3, 2022 19:13
@codecov
Copy link

codecov bot commented Feb 24, 2023

Codecov Report

Merging #61 (32590ce) into main (aad43d7) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #61      +/-   ##
==========================================
+ Coverage   97.63%   97.66%   +0.03%     
==========================================
  Files           5        5              
  Lines         466      472       +6     
  Branches       98      100       +2     
==========================================
+ Hits          455      461       +6     
  Misses         11       11              
Impacted Files Coverage Δ
src/hookable.ts 99.58% <100.00%> (+0.01%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@abarke
Copy link
Contributor

abarke commented Feb 28, 2023

I would welcome this 🥳 Thanks @nozomuikuta

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 💯

@pi0 pi0 merged commit 3deefd1 into unjs:main Mar 10, 2023
@nozomuikuta nozomuikuta deleted the feat/add-remove-all-hooks branch March 10, 2023 15:59
@abarke
Copy link
Contributor

abarke commented Mar 13, 2023

Thanks @nozomuikuta and @pi0 this is great 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is there a way to clear all hooks?
3 participants