Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix ptyxis VTE issues #1286

Open
castrojo opened this issue May 10, 2024 · 5 comments
Open

Fix ptyxis VTE issues #1286

castrojo opened this issue May 10, 2024 · 5 comments
Assignees
@castrojo

Comments

@castrojo
Copy link
Member

https://gitlab.gnome.org/chergert/ptyxis/-/issues/147#note_2109063

Bluefin does not have a patched VTE for the a11y support. Upstream Fedora 40 has our patches applied now and so we should probably direct Bluefin to just use the upstream vte291-gtk4 package when building the OS layers.
We don't have access to AdwButtonRow which means this must be using the main branch and not the stable gnome-46 branch. That is unexpected and we should get Bluefin using the actual stable branch.

I think we'll have ptyxis Fedora 40 packages upstream which might make this all easier very shortly as they can just pull that in rather than maintaining a downstream (is that the right word here?) package.
@KyleGospo
Copy link
Member

Checked VTE in both 40 and Rawhide, still not new enough.

Rebuilt Ptyxis with our VTE and gnome-46 branch.

@chergert
Copy link

Weird, because the vte-profile I have installed on F40 has the right patch, but when I look at https://src.fedoraproject.org/rpms/vte291/tree/f40 I don't see it.

@trafotin
Copy link

trafotin commented Jun 8, 2024

@chergert Would it be better to switch to the Flatpak of Ptyxis for future use? Given there was another issue opened 2 days ago about this issue and the profile works on the Flatpak.

For reference: https://gitlab.gnome.org/chergert/ptyxis/-/issues/159

@KyleGospo
Copy link
Member

@chergert Would it be better to switch to the Flatpak of Ptyxis for future use? Given there was another issue opened 2 days ago about this issue and the profile works on the Flatpak.

For reference: https://gitlab.gnome.org/chergert/ptyxis/-/issues/159

No. We wouldn't have a good way to install that for existing users that wouldn't fail for lack of an Internet connection, and may of the integrations we use with different desktop environments do not support the flatpak. That would also leave users with the ability to uninstall their only terminal.

We are very interested in the official Fedora RPM for Ptyxis however.

@castrojo castrojo assigned castrojo and unassigned KyleGospo Jul 9, 2024
@castrojo
Copy link
Member Author

castrojo commented Jul 9, 2024

We're just waiting for ptyxis to land in Fedora 40 (the deps have landed), and once we do that we'll be on the distro version and won't need to package it ourselves then we'll be good to go.

Once it lands I'll PR this.

@castrojo castrojo mentioned this issue Aug 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@castrojo castrojo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@chergert @castrojo @KyleGospo @trafotin