-
-
Notifications
You must be signed in to change notification settings - Fork 200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add DX Images #565
base: main
Are you sure you want to change the base?
feat: Add DX Images #565
Conversation
ARG BASE_IMAGE_NAME="${BASE_IMAGE_NAME}" | ||
ARG FEDORA_MAJOR_VERSION="${FEDORA_MAJOR_VERSION}" | ||
|
||
COPY system_files/deck/shared system_files/deck/${BASE_IMAGE_NAME} / |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of copying Deck files, we could move from this being an image target to an option so that DX desktop and DX Deck images can exist separately by adding another build flag that distinguishes itself between standard images and DX images
COPY --from=cgr.dev/chainguard/minio-client:latest /usr/bin/mc /usr/bin/mc | ||
|
||
# Install DevPod | ||
RUN rpm-ostree install https://github.com/loft-sh/devpod/releases/download/v0.3.7/DevPod_linux_x86_64.rpm && \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe I read that this is going to be provided as an AppImage only going into the future with only the CLI being provided as an RPM. We could install the CLI, and then have a dx entry in the portal that provides downloading the AppImage as an option if that sounds all right to you?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The plan was to COPR this one with the intent of seeing if someone can help us get it in fedora.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't mind looking into throwing it on COPR. I think that's the best bet as it would be nice for it to just be there out of the box
6e76538
to
7c8ad27
Compare
7484dae
to
12c4f12
Compare
268dd9b
to
6effacf
Compare
Any progress on DX version ? |
fceb14e
to
7ed7e7f
Compare
f3dd51f
to
3827f7d
Compare
Still planned, we'll be returning to this soon |
9403fa9
to
515b79f
Compare
a61bba1
to
8bd109a
Compare
Are you guys waiting on some external blockers, or do you need some manpower on this? I can provide the later one :D |
For the time being I built a "DX" image with bluebuild no nvidia builds yet since I use it on Intel and AMD GPUs however I can add the if someone needs it https://github.com/FlyinPancake/cirrus-os |
@@ -0,0 1,7 @@ | |||
if test "$(id -u)" -gt "0" && test -d "$HOME"; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
❌ Codacy found a critical Error Prone issue: Tips depend on target shell and yours is unknown. Add a shebang or a 'shell' directive.
The issue that ShellCheck is pointing out is that it does not know which shell interpreter you are targeting with your script. ShellCheck needs this information because different shells may have different syntax or support different features. A shebang line at the beginning of your script tells the operating system which interpreter to use when the script is executed, and it also informs ShellCheck which shell to assume when linting the code.
To fix this issue, you should add a shebang line to the top of your script to specify the shell you are using. If you are using Bash, which is common and seems to be the case based on your code, you would add the following line at the very beginning of your script:
if test "$(id -u)" -gt "0" && test -d "$HOME"; then | |
#!/bin/bash |
This comment was generated by an experimental AI tool.
53017fd
to
f11bcdd
Compare
#533