Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Imple Pre Copmonent #122

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Imple Pre Copmonent #122

merged 6 commits into from
Jul 17, 2024

Conversation

8845musign
Copy link
Collaborator

@8845musign 8845musign commented Jul 12, 2024 •
edited
Loading

Changes

  • Imple Pre Copmonent
  • Many places where CSS is written for white-space: pre-*.
  • The default value is pre-line, which omits consecutive spaces.
  • Based on span for placement in a variety of locations.

Screenshot

http://localhost:6006/?path=/docs/typography-pre--docs
スクリーンショット 2024-07-12 10 32 18

http://localhost:6006/?path=/story/typography-pre--white-space-pre

スクリーンショット 2024-07-12 10 32 23

http://localhost:6006/?path=/story/typography-pre--pre-wrap

スクリーンショット 2024-07-12 10 32 35

http://localhost:6006/?path=/story/typography-pre--inline

スクリーンショット 2024-07-12 10 32 40

Check

  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign self-assigned this Jul 12, 2024
@8845musign 8845musign marked this pull request as ready for review July 12, 2024 01:34
@8845musign
add prop comments
e9f6b92 
Signed-off-by: hiroki.yokouchi <[email protected]>
@takanorip takanorip merged commit 4e19e3b into ubie-oss:main Jul 17, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

Assignees

@8845musign 8845musign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip