Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Inline prop to box and flex component #121

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Add Inline prop to box and flex component #121

merged 6 commits into from
Jul 17, 2024
+67 −1

Conversation

8845musign
Copy link
Contributor

Changes

  • Add Inline prop to box and flex component

@tonkotsuboy @takanorip

Is vertical-align prop necessary? I have not implemented it because we thought I would combine it with Flex etc. when adjusting the layout.

Screenshot

http://localhost:6006/?path=/story/stories-box--inline

スクリーンショット 2024-07-11 18 30 15

http://localhost:6006/?path=/story/stories-flex--inline

スクリーンショット 2024-07-11 18 29 49

Check

  • Added new Component
    • Added data-* prop and id prop
  • Updated Ubie Vitals or Added an update issue(if needed)

@8845musign 8845musign requested a review from takanorip as a code owner July 11, 2024 09:30
@8845musign 8845musign self-assigned this Jul 11, 2024
@8845musign 8845musign requested a review from tonkotsuboy July 11, 2024 09:30
@takanorip takanorip merged commit 2c53526 into ubie-oss:main Jul 17, 2024
2 checks passed
@8845musign 8845musign deleted the inline-box-and-flex branch October 31, 2024 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@takanorip takanorip takanorip approved these changes

@tonkotsuboy tonkotsuboy Awaiting requested review from tonkotsuboy

Assignees

@8845musign 8845musign

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@8845musign @takanorip