Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error on SVG elements in widget_starter #92

Open
valentinzberea opened this issue Jun 4, 2013 · 0 comments · May be fixed by #93
Open

Error on SVG elements in widget_starter #92

valentinzberea opened this issue Jun 4, 2013 · 0 comments · May be fixed by #93
Assignees
@valentinzberea

Comments

@valentinzberea
Copy link
Contributor

An exception is thrown on this line: https://github.com/uberVU/mozaic/blob/master/core/widget_starter.coffee#L77
when you have SVG elements in DOM.

It seems to be quite common:
http://stackoverflow.com/questions/12588913/svganimatedstring-missing-method-indexof

The fix would be that instead of:

el.className

to use

if el.className.baseVal? then el.className.baseVal else el.className

like in this fix from d3.js: https://github.com/jasondavies/d3/commit/7ab5e3567f6c5976c90e30d13e5b6ee3890590f1
@ghost ghost assigned valentinzberea Jun 4, 2013
valentinzberea added a commit to valentinzberea/mozaic that referenced this issue Jun 4, 2013
@valentinzberea
Fixes uberVU#92
9f54536
@valentinzberea valentinzberea linked a pull request Jun 4, 2013 that will close this issue
Open
valentinzberea added a commit to valentinzberea/mozaic that referenced this issue Jun 5, 2013
@valentinzberea
Handle logic corner case in isMutationRecord uberVU#92
1f0cc7d
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@valentinzberea valentinzberea

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix for SVGAnimatedString handling in widget_starter valentinzberea/mozaic
1 participant
@valentinzberea