Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve default failed equality match output to more clearly show diffs #130

Open
takaaa220 opened this issue Dec 16, 2023 · 1 comment
Open

Improve default failed equality match output to more clearly show diffs #130

takaaa220 opened this issue Dec 16, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@takaaa220
Copy link

takaaa220 commented Dec 16, 2023 •
edited
Loading

Hi, maintainers! I would like to express my sincere gratitude for your efforts in maintaining gomock.

Requested feature
Is the issue golang/mock#616 resolved? If not, i hope improvement the diffs when tests fails.

I didn't find out whether the problem resolved or not as the original repository has the issue archived and cannot ask there.

Why the feature is needed
As showing the original issue, it is often hard to understand and interpret the diffs.

(Optional) Proposed solution
i think we can solve this problem by using the method indicated in the following comments:

Alternatively, adding an option to change the default matcher may resolve this, as it would allow for the use of this way.
@r-hang r-hang added the enhancement New feature or request label Dec 19, 2023
@tmc
Copy link

tmc commented Feb 9, 2024

The current diff output is pretty low readability. Would love to see the golang/mock#616 (comment) or something similar implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tmc @takaaa220 @r-hang