Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow registering search attributes even when AdvancedVisibility is not enabled #5085

Closed
longquanzheng opened this issue Feb 9, 2023 · 5 comments
Closed

Allow registering search attributes even when AdvancedVisibility is not enabled #5085

longquanzheng opened this issue Feb 9, 2023 · 5 comments
Labels
customer Feature asks from customer good first issue Up for grab as first issue to contribute to Cadence project

Comments

@longquanzheng
Copy link
Collaborator

cadence/service/frontend/adminHandler.go

Line 220 in 3b5c2b6

return adh.error(&types.BadRequestError{Message: "AdvancedVisibilityStore is not configured for this Cadence Cluster"}, scope)

This is already supported in Temporal.
With this, search attributes can be used as data fields and not for search.
It's a convenient to test the search attribute API in the workflow code before using advanced visibility.
@longquanzheng longquanzheng mentioned this issue Feb 9, 2023
Closed
@lancezhao-ins
Copy link
Contributor

Hi @longquanzheng ,
Does this ticket only require changing the validation around the line you mentioned?

@longquanzheng
Copy link
Collaborator Author

Hi @longquanzheng ,
Does this ticket only require changing the validation around the line you mentioned?

Yes I believe so.

@lancezhao-ins
Copy link
Contributor

Cool, can I pick it up as my first Open-Source ticket?

@longquanzheng
Copy link
Collaborator Author

Cool, can I pick it up as my first Open-Source ticket?

Sure, go ahead. Feel free to ask if you have more questions

@lancezhao-ins
Copy link
Contributor

PR Opened: #5185

@ibarrajo ibarrajo added customer Feature asks from customer good first issue Up for grab as first issue to contribute to Cadence project labels Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
customer Feature asks from customer good first issue Up for grab as first issue to contribute to Cadence project
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ibarrajo @longquanzheng @lancezhao-ins