Change the signature of World::main
#4531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current
World::maincannot process the case when the main source file may be gone or invalid at some time well. For example,typst-clihas to always add an extra checking before trapped intotypst::compile.Therefore, we would like to change the the signature of
World::maintofn main(&self) -> FileId. This decouples the world APIs a bit and makes it impossible to have a mismatch betweenworld.main()andworld.source(world.main().id())(which would be a logic error). The PR itself also proves it actually makes life of downstreams simpler.