Add sys.target export targets
#4385
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Relevant prior art: #1904 |
tingerrr
force-pushed
the
tingerrr/kprptzstusot
branch
3 times, most recently
from
2a37969
to
84ea4e0
Compare
|
I have renamed |
tingerrr
force-pushed
the
tingerrr/kprptzstusot
branch
2 times, most recently
from
442a179
to
24bbf33
Compare
|
I've changed the test runner to have three options, one for each export target, running only those that are selected. By default, The README contains a note explaining that only render tests are compared. |
tingerrr
force-pushed
the
tingerrr/kprptzstusot
branch
from
24bbf33
to
53fed93
Compare
laurmaedje
added
waiting-on-design
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
sys.target, a string variable containingpdf,svgorrasterdepending on the export target.It should be noted that, with this PR in its current stage, compilation is run 3 times per average test on
--extended. It may be more sensible, but less intuitive to contributors, if we assume a default target ofrasterand then only override the target for those test which have an appropriate annotation.TODO
Related to #4174, partially resolves it.