Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text show rules don't work across text nodes #86

Closed
laurmaedje opened this issue Sep 22, 2022 · 4 comments · Fixed by #4876
Closed

Text show rules don't work across text nodes #86

laurmaedje opened this issue Sep 22, 2022 · 4 comments · Fixed by #4876
Labels
bug Something isn't working styling About set and show rules or style properties

Comments

@laurmaedje
Copy link
Member

Since this produces two text nodes Text("A") and Text("/B"), the show rule doesn't work.

#show "A/B" as "Nope"
A/B
@ndtodoroff ndtodoroff mentioned this issue Mar 27, 2023
Closed
@reknih reknih added the bug Something isn't working label Apr 5, 2023
@astrale-sharp
Copy link
Contributor

I'm giving some attention to this

@astrale-sharp
Copy link
Contributor

Okay, I can't reproduce the bug, this issue should be closed I think

@laurmaedje
Copy link
Member Author

This reproduces it:

#show "A  B": "Nope"
A  B

Some lexer changes made the original thing work, but the bug still exists.

@astrale-sharp
Copy link
Contributor 

#show "A  B--C": "Nope"

doesn't work but your previous example does now

This was referenced Jan 29, 2024
Closed
Closed
@laurmaedje laurmaedje mentioned this issue Feb 2, 2024
Closed
1 task
@Enivex Enivex mentioned this issue Mar 16, 2024
Closed
1 task
@Enivex Enivex added the styling About set and show rules or style properties label Mar 16, 2024
@laurmaedje laurmaedje mentioned this issue Apr 3, 2024
Closed
1 task
@PgBiel PgBiel mentioned this issue Jun 3, 2024
Closed
1 task
@Enivex Enivex mentioned this issue Jul 8, 2024
Closed
1 task
@Enivex Enivex mentioned this issue Aug 4, 2024
Closed
1 task
@alexanderkoller alexanderkoller mentioned this issue Aug 5, 2024
Open
@flokl flokl mentioned this issue Aug 20, 2024
Closed
1 task
@admk admk mentioned this issue Aug 23, 2024
Open
@laurmaedje laurmaedje mentioned this issue Sep 2, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working styling About set and show rules or style properties
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New realization / Text show rules now work across elements typst/typst
4 participants
@Enivex @reknih @laurmaedje @astrale-sharp