Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notifications method to Session #506

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

dbdbdb
Copy link

@dbdbdb dbdbdb commented Jul 8, 2021

The documentation state that there should be a notifications function
on the Session to get events from all subscribed channels:

https://tpolecat.github.io/skunk/tutorial/Channels.html#listening-to-a-channel

The function existed on the protocol level but was missing in
the Session.

The documentation state that there should be a notifications function
on the Session to get events from all subscribed channels:

https://tpolecat.github.io/skunk/tutorial/Channels.html#listening-to-a-channel

The function existed on the protocol level but was missing in
the Session.
@matthughes
Copy link
Contributor

I know this is pretty old but has this been overcome by events @dbdbdb ? There is a listen method on Session that has the same type signature. How is that different than your proposed method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants