Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ruby: Fix auto_link so that it doesn't remove emoji #304

Merged
merged 1 commit into from
Mar 25, 2020
Merged

Ruby: Fix auto_link so that it doesn't remove emoji #304

merged 1 commit into from
Mar 25, 2020

Conversation

mocoso
Copy link
Contributor

@mocoso mocoso commented Mar 5, 2020

This fixes #275

@CLAassistant
Copy link

CLAassistant commented Mar 5, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@mocoso
Copy link
Contributor Author

mocoso commented Mar 15, 2020

Is there anything more that I can do to help get this merged?

@dlamacchia
Copy link
Contributor

Is there anything more that I can do to help get this merged?

Thanks for this patch, I'll check it out today.

dlamacchia
dlamacchia approved these changes Mar 25, 2020
View reviewed changes
Copy link
Contributor

@dlamacchia dlamacchia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code and local testing both look good. Approving this change. Thanks again for the submission.

@dlamacchia dlamacchia merged commit 03dcea5 into twitter:master Mar 25, 2020
@kaushlakers kaushlakers mentioned this pull request Mar 30, 2020
Merged
This was referenced Mar 17, 2021
Open
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlamacchia dlamacchia dlamacchia approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ruby: auto_link strips emoji
3 participants
@mocoso @CLAassistant @dlamacchia