Fix display issues of close button in contextual light and dark modes #41126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-deramond
force-pushed
the
main-jd-close-button-dark-theme
branch
2 times, most recently
from
2a67d59 to
577dcb0
Compare
julien-deramond
force-pushed
the
main-jd-close-button-dark-theme
branch
from
577dcb0 to
761d57e
Compare
louismaximepiton
approved these changes
Dec 31, 2024
I forgot to mention it in the description, you're right. I don't think that the override of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caution
Before merging,
close-button.mdmodifications must be revertedDescription
Following up the PR for the carousel display issues in contextual light and dark modes at #40695, this PR also fixes the same kind of
filterissue.This PR will close #39765.
The light in dark mode doesn't work in the main branch:
The idea is to rely on custom properties so that there's never a specificity issue when nesting color modes (light mode in dark mode, and dark mode in light mode) (see more info in #40695)
/cc @louismaximepiton
Type of changes
Checklist
npm run lint)Live previews
Related issues
Closes #39765