-
-
Notifications
You must be signed in to change notification settings - Fork 78.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make both .scale(X) and .scale(X, Y) both work #12459
Conversation
Your solution still doesn't work. |
@zdroid Perhaps you could give a little more clue about why you believe it's not working. I'm using the patch with success. |
It produces incorrect syntax. 2014-02-01 rubenstolk [email protected]:
|
You're right. Will fix it. |
Definitely working now, thanks @zdroid, that ... notation was anyways a bad idea which I was tempted to use since it was already in code. |
Someone advice me if this notation could be preferred over current code:
In that case we should do the same for rotate etc. |
scale, scaleX and scaleY should be good idea. 2014-02-01 rubenstolk [email protected]:
Zlatan Vasović - ZDroid |
Yes, but do we want scaleX and scaleY to translate to native CSS scaleX and scaleY (current code), resulting in longer and less maintainable LESS-code, or the suggestion that I gave above. Not sure what the guidelines are... |
/cc @mdo |
Squash to one commit please and we can merge. |
@mdo done. Please do still advice if we should rather follow the notation that I suggested a few comments up... |
Make both .scale(X) and .scale(X, Y) both work
Make both .scale(X) and .scale(X, Y) both work
Since the ... notation anyways accepts multiple parameters, it was completely unnecessary to have two parameters.
#11748 was made as a patch for this, however just using .scale(X) would not work in this scenario since it is still expecting at least two parameters.