Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make both .scale(X) and .scale(X, Y) both work #12459

Merged
merged 1 commit into from
Feb 22, 2014

Conversation

rubenstolk
Copy link
Contributor

Since the ... notation anyways accepts multiple parameters, it was completely unnecessary to have two parameters.
#11748 was made as a patch for this, however just using .scale(X) would not work in this scenario since it is still expecting at least two parameters.

@zlatanvasovic
Copy link
Contributor

Your solution still doesn't work.

@rubenstolk
Copy link
Contributor Author

@zdroid Perhaps you could give a little more clue about why you believe it's not working. I'm using the patch with success.

@zlatanvasovic
Copy link
Contributor

It produces incorrect syntax. .scale(100, 5) produces ... scale(100 5)
instead of ... scale(100, 5).

2014-02-01 rubenstolk [email protected]:

@zdroid https://github.com/ZDroid Perhaps you could give a little more
clue about why you believe it's not working. I'm using the patch with
success.

@rubenstolk
Copy link
Contributor Author

You're right. Will fix it.

@rubenstolk
Copy link
Contributor Author

Definitely working now, thanks @zdroid, that ... notation was anyways a bad idea which I was tempted to use since it was already in code.

@rubenstolk
Copy link
Contributor Author

Someone advice me if this notation could be preferred over current code:

.scale(@ratioX, @ratioY) {
  -webkit-transform: scale(@ratioX, @ratioY);
      -ms-transform: scale(@ratioX, @ratioY); // IE9 only
          transform: scale(@ratioX, @ratioY);
}
.scale(@ratio) {
  .scale(@ratio, @ratio);
}
.scaleX(@ratio) {
  .scale(@ratio, 1);
}
.scaleY(@ratio) {
  .scale(1, @ratio);
}

In that case we should do the same for rotate etc.

@zlatanvasovic
Copy link
Contributor

scale, scaleX and scaleY should be good idea.

2014-02-01 rubenstolk [email protected]:

Someone advice me if this notation could be preferred over current code:

.scale(@ratioX, @ratioY) {
-webkit-transform: scale(@ratioX, @ratioY);
-ms-transform: scale(@ratioX, @ratioY); // IE9 only
transform: scale(@ratioX, @ratioY);
}
.scale(@ratio) {
.scale(@ratio, @ratio);
}
.scaleX(@ratio) {
.scale(@ratio, 1);
}
.scaleY(@ratio) {
.scale(1, @ratio);
}


Reply to this email directly or view it on GitHubhttps://github.com//pull/12459#issuecomment-33869458
.

Zlatan Vasović - ZDroid

@rubenstolk
Copy link
Contributor Author

Yes, but do we want scaleX and scaleY to translate to native CSS scaleX and scaleY (current code), resulting in longer and less maintainable LESS-code, or the suggestion that I gave above. Not sure what the guidelines are...

@zlatanvasovic
Copy link
Contributor

/cc @mdo

@mdo
Copy link
Member

mdo commented Feb 9, 2014

Squash to one commit please and we can merge.

@cvrebert cvrebert self-assigned this Feb 9, 2014
@rubenstolk
Copy link
Contributor Author

@mdo done. Please do still advice if we should rather follow the notation that I suggested a few comments up...

@cvrebert cvrebert removed their assignment Feb 10, 2014
@mdo mdo modified the milestones: v3.2.0, v3.1.1 Feb 11, 2014
mdo added a commit that referenced this pull request Feb 22, 2014
Make both .scale(X) and .scale(X, Y) both work
@mdo mdo merged commit b01f995 into twbs:master Feb 22, 2014
@mdo mdo mentioned this pull request Feb 22, 2014
stempler pushed a commit to stempler/bootstrap that referenced this pull request Nov 4, 2014
Make both .scale(X) and .scale(X, Y) both work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants