removed color treatment of outline for easier integration #11551
Conversation
|
I have no opinion personally, but I am going to point out that I've seen complaints from some perfectionists who find the default dotted outlines ugly; the special WebKit styling throws them a bone in that regard. |
|
@cvrebert - Thanks for chime in, and I am all for throwing a bone when we can, but since outline is one of those areas branded by accessibility [http://www.w3.org/TR/WCAG-TECHS/F78.html], styling colour in that property maybe a slippery slope, when natively browsers are already doing it for you safely, IMHO. Keep up the great work guys 👍 |
|
I don't think I want to remove the WebKit |
|
@mdo , thanks for the response. will update my PR to address. |
|
@masterbee Could you squash this into a single commit? If not, I can, when @mdo gives the go-ahead. |
|
@cvrebert - all set thanks for the patience. |
removed color treatment of outline for easier integration
removed color treatment of outline for easier integration
removed color treatment of outline for easier integration
invertwhich ensures that the outline colour will always have sufficient contrast from the background it is on..tab-focus()mixin was styling the background colour to#333, this poses a bit of a restriction for implementers of twitter bootstrap since if the background is darker than white, there may not be enough contrast to see the outline, causing an accessibility issue.Great work again TB team, looking forward to v3.0.3
/cc @mdo @cvrebert