Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing Sender Name doesn't work #7254

Open
murilopereirame opened this issue Jul 22, 2024 · 2 comments
Open

Removing Sender Name doesn't work #7254

murilopereirame opened this issue Jul 22, 2024 · 2 comments
Labels
bug broken functionality, usability problems, unexpected errors

Comments

@murilopereirame
Copy link
Contributor

Describe the bug
When setting the Sender Name to an empty string, the client doesn't return any error or warnings and restore what was set before.

To Reproduce
Steps to reproduce the behavior:

  1. Go to Settings > Email
  2. Set the "Sender name" to an empty string
  3. Click again to change the sender name, see that the data wasn't erased.

Expected behavior
The sender name is empty.
@murilopereirame murilopereirame added the bug broken functionality, usability problems, unexpected errors label Jul 22, 2024
@rezbyte
Copy link
Contributor

rezbyte commented Jul 24, 2024

Thanks for your report.

I suspect this is intentional behaviour. Removing the sender name will just display the email address to recipients.

@murilopereirame
Copy link
Contributor Author

Thanks for your report.

I suspect this is intentional behaviour. Removing the sender name will just display the email address to recipients.

Then the Dialog shouldn't allow saving or it should throw an error. My main concern is that it returns success for an operation that will not be applied

@charlag charlag changed the title Removig Sender Name doesn't work Removing Sender Name doesn't work Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug broken functionality, usability problems, unexpected errors
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@murilopereirame @rezbyte