Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: AppRouteDeleteNoBody should resolve to AppRouteQueryImplementation type #713

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

AndrewJo
Copy link

@AndrewJo AndrewJo commented Nov 9, 2024

Fixes #712.

This is mainly a fix for the typing system and does not break existing tests which was run with pnpm nx affected:test.

Copy link

changeset-bot bot commented Nov 9, 2024

🦋 Changeset detected

Latest commit: f7f765c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@ts-rest/express Patch
@ts-rest/example-contracts Patch
@ts-rest/non-strict-mode-test Patch
@ts-rest/core Patch
@ts-rest/fastify Patch
@ts-rest/nest Patch
@ts-rest/next Patch
@ts-rest/open-api Patch
@ts-rest/react-query-v5 Patch
@ts-rest/react-query Patch
@ts-rest/serverless Patch
@ts-rest/solid-query Patch
@ts-rest/vue-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

vercel bot commented Nov 9, 2024

@AndrewJo is attempting to deploy a commit to the ts-rest Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

sonarcloud bot commented Nov 9, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ts-rest/express optional body in DELETE endpoint (AppRouteDeleteNoBody) causes type errors in route handlers
1 participant