Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle ContractOtherResponse type when generating OpenAPI #709

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ryo-kam
Copy link

@ryo-kam ryo-kam commented Oct 19, 2024

Changes

Handle ContractOtherResponse when generating OpenAPI for the API responses, so that it can generate non-'application/json' media type responses; for example 'application/problem json' to return error responses according to the problem detail standard.

Before

image

After

image

Copy link

changeset-bot bot commented Oct 19, 2024

⚠️ No Changeset found

Latest commit: 07b70d3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Oct 19, 2024

@ryo-kam is attempting to deploy a commit to the ts-rest Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

sonarcloud bot commented Oct 19, 2024

@ryo-kam ryo-kam changed the title Handle ContractOtherResponse type when generating OpenAPI Fix: Handle ContractOtherResponse type when generating OpenAPI Oct 19, 2024
Copy link

@ChristianF1 ChristianF1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@bompi88 bompi88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM too 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants