Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mount system dataset on passive node #326

Merged
merged 1 commit into from
Sep 29, 2017
Merged

Mount system dataset on passive node #326

merged 1 commit into from
Sep 29, 2017

Conversation

jhixson74
Copy link

Ticket: #25742

william-gr
william-gr approved these changes Sep 28, 2017
View reviewed changes
Copy link
Member

@william-gr william-gr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cant comment on the behavior of such change since I have no tested, but from a code perspective, looks ok to me.

@william-gr
Copy link
Member

william-gr commented Sep 28, 2017 •
edited
Loading

Can we get a PR for master as well? Code diverges.

@jhixson74
Copy link
Author

I'm waiting for a HA setup running master for this, but yes, I plan to get this into master ASAP.

@kmoore134
Copy link
Contributor

Jenkins: retest this please
(Ignore, using it to try something in Jenkins)

@vaibhav-rbs vaibhav-rbs merged commit 88b3ead into freenas/11.0-stable Sep 29, 2017
@jhixson74 jhixson74 deleted the freenas/11.0-stable-AD-HA-fixes branch April 9, 2018 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@william-gr william-gr william-gr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jhixson74 @william-gr @kmoore134 @vaibhav-rbs