@uppy/dashboard: fix handling of null for doneButtonHandler
#5283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As documented, `null` should not be treated the same as `undefined`.
Diff output filesdiff --git a/packages/@uppy/dashboard/lib/Dashboard.js b/packages/@uppy/dashboard/lib/Dashboard.js
index 05cad99..31f37a0 100644
--- a/packages/@uppy/dashboard/lib/Dashboard.js
b/packages/@uppy/dashboard/lib/Dashboard.js
@@ -74,7 74,7 @@ const defaultOptions = {
autoOpenFileEditor: false,
disabled: false,
disableLocalFiles: false,
- doneButtonHandler: null,
doneButtonHandler: undefined,
onRequestCloseModal: null,
};
var _disabledNodes = _classPrivateFieldLooseKey("disabledNodes");
@@ -90,7 90,7 @@ var _autoDiscoverPlugins = _classPrivateFieldLooseKey("autoDiscoverPlugins");
var _addSupportedPluginIfNoTarget = _classPrivateFieldLooseKey("addSupportedPluginIfNoTarget");
export default class Dashboard extends UIPlugin {
constructor(uppy, _opts) {
- var _this$opts4, _this$opts4$doneButto, _this$opts5, _this$opts5$onRequest;
var _this$opts4, _this$opts4$onRequest;
let autoOpen;
if (!_opts) {
autoOpen = null;
@@ -1071,15 1071,15 @@ export default class Dashboard extends UIPlugin {
this.title = "Dashboard";
this.type = "orchestrator";
this.defaultLocale = locale;
- (_this$opts4$doneButto = (_this$opts4 = this.opts).doneButtonHandler) != null
- ? _this$opts4$doneButto
- : _this$opts4.doneButtonHandler = () => {
if (this.opts.doneButtonHandler === undefined) {
this.opts.doneButtonHandler = () => {
this.uppy.clearUploadedFiles();
this.requestCloseModal();
};
- (_this$opts5$onRequest = (_this$opts5 = this.opts).onRequestCloseModal) != null
- ? _this$opts5$onRequest
- : _this$opts5.onRequestCloseModal = () => this.closeModal();
}
(_this$opts4$onRequest = (_this$opts4 = this.opts).onRequestCloseModal) != null
? _this$opts4$onRequest
: _this$opts4.onRequestCloseModal = () => this.closeModal();
this.i18nInit();
}
} |
github-actions bot
added a commit
that referenced
this pull request
Jun 27, 2024
| Package | Version | Package | Version | | ---------------- | ------- | ---------------- | ------- | | @uppy/dashboard | 3.9.1 | uppy | 3.27.1 | | @uppy/xhr-upload | 3.6.8 | | | - @uppy/xhr-upload: add `'PATCH'` as valid method (Quinn Daley / #5279) - @uppy/dashboard: fix handling of `null` for `doneButtonHandler` (Antoine du Hamel / #5283) - meta: Bump docker/build-push-action from 5.4.0 to 6.1.0 (dependabot[bot] / #5272) - docs: rewrite Instagram dev setup section (Evgenia Karunus / #5274) - meta: remove the Zoom section from `CONTRIBUTING.md` (Evgenia Karunus / #5273)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented,
nullshould not be treated the same asundefined.Fixes: #5282