Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

i18n "Shared with me" etc #5294

Open
2 tasks done
mifi opened this issue Jul 1, 2024 · 1 comment
Open
2 tasks done

i18n "Shared with me" etc #5294

mifi opened this issue Jul 1, 2024 · 1 comment
Labels
Feature

Comments

@mifi
Copy link
Contributor

mifi commented Jul 1, 2024

Initial checklist

  • I understand this is a feature request and questions should be posted in the Community Forum
  • I searched issues and couldn’t find anything (or linked relevant results below)

Problem

Fake folders like "Shared with me" (Google Drive / Photos) is currently hardcoded in Companion and returned to Uppy and therefore cannot be i18n in the client.

uppy/packages/@uppy/companion/src/server/provider/google/drive/adapter.js

Line 174 in 46e6be8

name: 'Shared with me',

Solution

Not sure the best way to support i18n, but maybe leave name as undefined and have a separate field named something like specialFolderType which can then be i18n in the Uppy frontend? (maybe Uppy can set name to this i18n value when it receives a folder with specialFolderType from companion)

see also #5275 (comment)

Alternatives

implement i18n in companion too and detect the client's language
@mifi mifi added the Feature label Jul 1, 2024
@lakesare
Copy link
Contributor

lakesare commented Jul 2, 2024

Agreed we should translate "Shared with me"/"Albums"/"Timeline".
The solution you described sounds good to me, given partialTreeFolder.data.name gets filled with the i18n value as soon as the file is fetched, making item.data.name always a string.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mifi @lakesare