-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Errors in TypeScript definitions when installed with pnpm #5164
Comments
are you saying the same works with npm or yarn? that means that pnpm is doing something differently with the node_modules file structure (?) |
hmm, it seems to be installing the modules inside |
@mifi it's unrelated to pnpm, the error reported are in the @andersk interesting, it looks like those have been here for a long time and never were reported/noticed 🤔 FWIW we already have removed that file in the 4.x beta line, if you try with |
To confirm, I was able to get rid of the error with the following: $ pnpm i @uppy/core@next
Packages: 4 -4
----
Progress: resolved 11, reused 7, downloaded 4, added 4, done
dependencies:
- @uppy/core 3.11.3
@uppy/core 4.0.0-beta.7
Done in 3.6s
$ pnpm exec tsc --target es6 test.ts One of the changes we made in the 4.x branch was to switch our source files to TS, as the manually curated |
3.x should be in a good state for quite a while still as the vast majority of people are on it and will stay on it. Therefor I think we should fix it. |
Does everything work for you on 4.x? |
Initial checklist
Link to runnable example
No response
Steps to reproduce
From an empty directory:
Expected behavior
No errors.
Actual behavior
Several errors:
The text was updated successfully, but these errors were encountered: