-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@uppy/vue
requires installing dashboard even if it's not used
#4089
Comments
same problem with |
The workaround is to import the individual modules: import DragDrop from '@uppy/vue/lib/drag-drop.js'
import StatusBar from '@uppy/vue/lib/status-bar.js' We should probably update the docs to only show imports that targets the individual components modules. We also still have the possibility to put back the uppy plugins as direct dependencies instead of peers in a semver-minor, so if someone feels like it would be a better option, please speak up. |
I didn't know these kind of imports were required when you use peer dependencies. If we can't import from |
Just for the sake of simplicity of using it, I would prefer that. Would |
It would be tree-shaken. But the install footprint is bigger. I think we are going to try to add exports map to see if we can have normal imports with peer deps |
@aduh95. I'm using my own UI for uppy. Strictly using uppy as the infra so to speak. This was my packages:
Upgrading from 2.3.3 to the latest is now asking me to install dashboard and then uppy/drag-drop and that's when I reverted. I won't be using any of the new features, I don't need them. So I shouldn't have to install the unneeded packages? Thanks! |
@paulm17 It's still installing them automatically for you, since they're direct dependencies of |
@a-kriya If that's the case. Why am I getting, when I upgrade the dependencies I listed above:
Anyway, let me clarify so there is no confusion.
I would vote to revert back to how 2.x handles this issue. |
@paulm17 Things changed in v3 as I mentioned above. What I'll say is, you can upgrade to v3 and the only additional thing you have to do is list
And you'll notice that it's there in both cases.
Yep, that is what the maintainers will figure out for this ticket. |
@paulm17 to clarify, you don't have to download all the Uppy plugins if you change your code to only import the things you need – if you |
1 similar comment
@paulm17 to clarify, you don't have to download all the Uppy plugins if you change your code to only import the things you need – if you |
I did not know that! Works and I'm a happy camper, thanks a lot! 🥳 You can disregard my previous comment, as this change makes it superfluous. |
Requires additional declaration in a separate .d.ts file when importing in a TS project. |
We do include those |
1 year later, and this issue still isn't solved... Using
|
@entinio feel free to send a pull request |
Initial checklist
Link to runnable example
No response
Steps to reproduce
npm i @uppy/core @uppy/vue @uppy/drag-drop @uppy/status-bar
DragDrop
and/orStatusBar
:import {DragDrop, StatusBar} from '@uppy/vue'
Expected behavior
Successful build.
From https://uppy.io/docs/migration-guides.html#uppy-vue
Actual behavior
Build failure:
The text was updated successfully, but these errors were encountered: