Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Companion improvements #3284

Open
2 of 11 tasks
mifi opened this issue Nov 1, 2021 · 6 comments
Open
2 of 11 tasks

Companion improvements #3284

mifi opened this issue Nov 1, 2021 · 6 comments
Labels
Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) Feature

Comments

@mifi
Copy link
Contributor

mifi commented Nov 1, 2021

Discovered while working on #3159:

Discovered while working on #3953

  • upgrade got to v12, so that we can get rid of the unmaintained form-data module, see Remove request and form-data from companion #3496. This might be a big task because we possibly would need to rewrite Companion to ESM.
  • /logout endpoint in companion has side effects and I think should not be a GET (this is a client-server API breaking change so maybe it won't happen ever)
    app.get('/:providerName/logout', middlewares.hasSessionAndProvider, middlewares.gentleVerifyToken, controllers.logout)

Moved from trello

  • make Instagrams thumbnails smaller, maybe transcode them on-the-fly in companion

Write tests:

@mifi mifi added Feature Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) Triage labels Nov 1, 2021
@Murderlon
Copy link
Member

Can we merge this issue into #3180? and perhaps the last point can go into #3268?

@mifi
Copy link
Contributor Author

mifi commented Nov 2, 2021

I think this issue is different from #3180. #3180 is about small breaking changes we want to do in the next major. This issue is more about non-breaking changes which would improve companion, but I didn't want to make an issue for each of the improvements, as we would end up with very many issues then. And I didn't find any other place they fit in, so I put them here.

I'll move the last point to #3268 👍

@Acconut
Copy link
Member

Acconut commented Jun 7, 2022

Regarding:

pause/resume tus upload does not work properly with streamingUpload: true (currently defaults to false), due to this issue: tus/tus-js-client#275

The linked issue is now fixed in tus-js-client v3.0.0-0 (still a prerelease). tus-js-client is able to properly pause and resume even when the data source is an in-memory stream. Note that tus-js-client will create an in-memory buffer of the size defined in its chunkSize option.

Just wanted to let you know that the depending issue in tus-js-client is now resolved.

@mifi
Copy link
Contributor Author

mifi commented Jun 27, 2022

Great! From my testing it seems to be working nicely. Shall we make companion depend on v3.0.0-0 or do you want to release this as a v2 in tus-js-client?

@Acconut
Copy link
Member

Acconut commented Aug 9, 2022

Uppy now uses tus-js-client v3. Is there anything else that needs to be done (in uppy or tus-js-client) for this issue here?

@mifi
Copy link
Contributor Author

mifi commented Aug 10, 2022

Not that I know of. AFAIK Tus supports uploading streams with unknown length so it should be good.

@arturi arturi removed the Triage label Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Companion The auth server (for Instagram, GDrive, etc) and upload proxy (for S3) Feature
Projects
None yet
Development

No branches or pull requests

4 participants