Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Ubuntu 19.04 #1405

Merged
merged 2 commits into from
May 30, 2019
Merged

Support for Ubuntu 19.04 #1405

merged 2 commits into from
May 30, 2019

Conversation

jackivanov
Copy link
Collaborator

@jackivanov jackivanov commented Apr 25, 2019 •
edited
Loading

Description

Move some providers to Ubuntu 19.04 by default:

  • DigitalOcean
  • EC2
  • GCE
  • Azure
  • Vultr

Motivation and Context

A new Ubuntu release 19.04 (Disco Dingo) recently came out with updated StrongSwan version (5.7.1) where many of bugs, vulnerabilities and security issues fixed. Although not all providers currently support 19.04, the effort required on our end to support both versions is minimal. Dnscrypt-proxy is now included in the standard ubuntu repositories. Also, we provide a modified apparmor profile for charon because of a bug

How Has This Been Tested?

Deployed to the providers above on both 18.04 and 19.04 TravisCI tests

Types of changes

  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@jackivanov jackivanov added the 1.1 label Apr 25, 2019
@jackivanov jackivanov added this to the 1.1 milestone Apr 25, 2019
@jackivanov jackivanov changed the base branch from master to fix-213 April 25, 2019 09:10
@jackivanov jackivanov force-pushed the ubuntu-1904 branch 2 times, most recently from d7e9b66 to 1150e55 Compare April 26, 2019 09:19
@davidemyers
Copy link
Contributor

These messages appear to be new, but I don't know if they're serious:

Apr 26 13:53:37 vpn5 kernel: audit: type=1107 audit(1556286817.984:33): pid=766 uid=103 auid=4294967295 ses=4294967295 msg='apparmor="DENIED" operation="dbus_method_call"  bus="system" path="/org/freedesktop/systemd1" interface="org.freedesktop.systemd1.Manager" member="GetDynamicUsers" mask="send" name="org.freedesktop.systemd1" pid=849 label="/usr/lib/ipsec/charon" peer_pid=1 peer_label="unconfined"
Apr 26 13:53:37 vpn5 audit[766]: USER_AVC pid=766 uid=103 auid=4294967295 ses=4294967295 msg='apparmor="DENIED" operation="dbus_method_call"  bus="system" path="/org/freedesktop/systemd1" interface="org.freedesktop.systemd1.Manager" member="GetDynamicUsers" mask="send" name="org.freedesktop.systemd1" pid=849 label="/usr/lib/ipsec/charon" peer_pid=1 peer_label="unconfined"

@jackivanov
Copy link
Collaborator Author

@davidemyers not serious and doesn't affect Algo

@jackivanov jackivanov marked this pull request as ready for review April 26, 2019 15:58
@jackivanov jackivanov changed the base branch from fix-213 to master April 26, 2019 16:01
@jackivanov jackivanov changed the base branch from master to fix-213 April 26, 2019 16:01
@jackivanov jackivanov changed the base branch from fix-213 to master April 26, 2019 16:05
@jackivanov jackivanov mentioned this pull request May 7, 2019
Closed
@jackivanov jackivanov requested a review from dguido May 7, 2019 16:48
@jackivanov jackivanov merged commit a2fdc50 into master May 30, 2019
@jackivanov jackivanov deleted the ubuntu-1904 branch May 30, 2019 18:57
iBringit added a commit to iBringit/algo that referenced this pull request Nov 4, 2020
@iBringit
Revert "Support for Ubuntu 19.04 (trailofbits#1405)"
aab76af 
This reverts commit a2fdc50.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dguido dguido Awaiting requested review from dguido

Assignees
No one assigned
Labels
1.1
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@jackivanov @davidemyers