Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Adblock lists #1394

Merged
merged 1 commit into from
Apr 17, 2019
Merged

Update Adblock lists #1394

merged 1 commit into from
Apr 17, 2019

Conversation

TC1977
Copy link
Contributor

@TC1977 TC1977 commented Apr 14, 2019

Uses the Unified hosts file from @StevenBlack available here. This encompasses the Ad Away, MVPS, and Malware Domain lists, deleting duplicates for us, and also adds a bunch more.

Description

Running Adblock.sh with existing ad block lists:

Apr 14 17:58:38 algo-Apr-2019 systemd[1]: Started dnsmasq - A lightweight DHCP and caching DNS server.
Apr 14 17:58:38 algo-Apr-2019 dnsmasq[16562]: using nameserver 127.0.2.1#53
Apr 14 17:58:38 algo-Apr-2019 dnsmasq[16562]: using 54627 more local addresses
Apr 14 17:58:38 algo-Apr-2019 dnsmasq[16562]: read /etc/hosts - 5 addresses

Running Adblock.sh with new block lists:

Apr 14 18:01:30 algo-Apr-2019 systemd[1]: Started dnsmasq - A lightweight DHCP and caching DNS server.
Apr 14 18:01:30 algo-Apr-2019 dnsmasq[16628]: using nameserver 127.0.2.1#53
Apr 14 18:01:30 algo-Apr-2019 dnsmasq[16628]: using 77939 more local addresses
Apr 14 18:01:30 algo-Apr-2019 dnsmasq[16628]: read /etc/hosts - 5 addresses

Motivation and Context

Uses a more comprehensive, actively curated block list.
Probably makes running the script on the Algo server slightly faster, as duplicates among the upstream sources have been deleted for us.

How Has This Been Tested?

Changed the BLOCKLIST_URLS in /usr/local/sbin/adblock.sh in existing Vultr and Lightsail installations.

It's always possible this (like any other ad blacklist) may end up blocking a site that's actually desired.

Types of changes

  • [] Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • [] Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • I have added tests to cover my changes.

Uses the Unified hosts file from @StevenBlack available [here](https://github.com/StevenBlack/hosts). This encompasses the Ad Away, MVPS, and Malware Domain lists, deleting duplicates for us, and also adds a bunch more.
@jackivanov jackivanov merged commit a1117ec into trailofbits:master Apr 17, 2019
@TC1977 TC1977 deleted the patch-1 branch April 17, 2019 13:31
andreimc added a commit to tunnelhero/algo that referenced this pull request Apr 29, 2019
* upstream/master: (22 commits)
  Automatically create cloud firewall rules for installs onto Vultr (trailofbits#1400)
  Refactoring, Linting and additional tests (trailofbits#1397)
  Update Linux WireGuard client instructions (trailofbits#1407)
  Update cloud-vultr.md (trailofbits#1406)
  Update openssl.yml (trailofbits#1403)
  Update deploy-from-script-or-cloud-init-to-localhost.md
  Update README.md (trailofbits#1380)
  Update Adblock lists (trailofbits#1394)
  fix: get public IP from default interface (trailofbits#1396)
  Move `Delete the CA key` task to the appropriate role (trailofbits#1393)
  Update deploy-from-script-or-cloud-init-to-localhost.md
  Consolidate firewall documentation (trailofbits#1386)
  Fix 963 again (trailofbits#1379)
  Refactoring to support roles inclusion (trailofbits#1365)
  Update DNS filtering advice in FAQ (trailofbits#1389)
  Use VULTR_API_CONFIG variable if set (trailofbits#1374)
  IPv6 range to AllowedIPs only when ipv6_support (trailofbits#1388)
  Update ubuntu.yml (trailofbits#1383)
  Script to support cloud-init and local easy deploy (trailofbits#1366)
  Update 10-algo-lo100.network.j2 (trailofbits#1369)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants