Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include roles as separate tasks #1365

Merged
merged 1 commit into from
Apr 8, 2019
Merged

Include roles as separate tasks #1365

merged 1 commit into from
Apr 8, 2019

Conversation

jackivanov
Copy link
Collaborator

@jackivanov jackivanov commented Mar 20, 2019 •
edited
Loading

Description

  • Moves all the roles from the roles: state to include_ and import_ modules inside the tasks: state
  • Makes fail_hint globally instead of per role usage. Closes Error message is missing for some roles #1364
  • Changes stdout_callback from full_skip to default with display_skipped_hosts=no

Motivation and Context

The PR includes a lot of additions and deletions, because of changed indents, but there is actually only a few changes.
Most of the changes are to support further movements towards to the 1.1 goal.

How Has This Been Tested?

Deployed to Lightsail and DigitalOcean

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist:

  • I have read the CONTRIBUTING document.
  • My code follows the code style of this project.
  • All new and existing tests passed.

@jackivanov jackivanov added the 1.1 label Mar 20, 2019
@jackivanov jackivanov added this to the 1.1 milestone Mar 20, 2019
@dguido dguido merged commit c4ea880 into master Apr 8, 2019
@dguido dguido deleted the fix-1364 branch April 8, 2019 20:20
@ejheil ejheil mentioned this pull request Apr 9, 2019
Closed
andreimc added a commit to tunnelhero/algo that referenced this pull request Apr 29, 2019
@andreimc
Merge remote-tracking branch 'upstream/master'
f41d47e 
* upstream/master: (22 commits)
  Automatically create cloud firewall rules for installs onto Vultr (trailofbits#1400)
  Refactoring, Linting and additional tests (trailofbits#1397)
  Update Linux WireGuard client instructions (trailofbits#1407)
  Update cloud-vultr.md (trailofbits#1406)
  Update openssl.yml (trailofbits#1403)
  Update deploy-from-script-or-cloud-init-to-localhost.md
  Update README.md (trailofbits#1380)
  Update Adblock lists (trailofbits#1394)
  fix: get public IP from default interface (trailofbits#1396)
  Move `Delete the CA key` task to the appropriate role (trailofbits#1393)
  Update deploy-from-script-or-cloud-init-to-localhost.md
  Consolidate firewall documentation (trailofbits#1386)
  Fix 963 again (trailofbits#1379)
  Refactoring to support roles inclusion (trailofbits#1365)
  Update DNS filtering advice in FAQ (trailofbits#1389)
  Use VULTR_API_CONFIG variable if set (trailofbits#1374)
  IPv6 range to AllowedIPs only when ipv6_support (trailofbits#1388)
  Update ubuntu.yml (trailofbits#1383)
  Script to support cloud-init and local easy deploy (trailofbits#1366)
  Update 10-algo-lo100.network.j2 (trailofbits#1369)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
1.1 deploy_enhancements
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.

Error message is missing for some roles
2 participants
@jackivanov @dguido