Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New autodiff graph memory management strategy #1698

Merged
merged 9 commits into from
Apr 26, 2024
Merged

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Apr 26, 2024

I reworked the graph memory management strategy in the autodiff backend.
Fix #1669

Copy link

codecov bot commented Apr 26, 2024

Codecov Report

Attention: Patch coverage is 99.43343% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 86.45%. Comparing base (2140d9b) to head (085de2c).
Report is 16 commits behind head on main.

Files Patch % Lines
crates/burn-autodiff/src/ops/base.rs 50.00% 1 Missing ⚠️
...tes/burn-autodiff/src/runtime/memory_management.rs 98.87% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1698       /-   ##
==========================================
  Coverage   86.41%   86.45%    0.04%     
==========================================
  Files         694      696        2     
  Lines       80635    81236      601     
==========================================
  Hits        69677    70233      556     
- Misses      10958    11003       45     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nathanielsimard nathanielsimard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nathanielsimard nathanielsimard merged commit 6ae3926 into main Apr 26, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/perf/autodiff branch April 26, 2024 16:25
syl20bnr pushed a commit that referenced this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

performance regression in training FSRS
2 participants