Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[backend-comparison] Add all choice to --benches and --backends #1567

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

syl20bnr
Copy link
Member

@syl20bnr syl20bnr commented Apr 1, 2024

Pull Request Template

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.

Related Issues/PRs

n/a

Changes

Add all choice to --benches and --backends and make some tweaks in logs.

Testing

cargo run --release --bin burnbench -- list

cargo run --release --bin burnbench -- run --benches all --backends all

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 0% with 24 lines in your changes are missing coverage. Please review.

Project coverage is 86.29%. Comparing base (edcd92f) to head (aaca8ca).
Report is 3 commits behind head on main.

Files Patch % Lines
backend-comparison/src/burnbenchapp/base.rs 0.00% 21 Missing ⚠️
backend-comparison/src/persistence/base.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1567       /-   ##
==========================================
- Coverage   86.31%   86.29%   -0.03%     
==========================================
  Files         683      683              
  Lines       78091    78115       24     
==========================================
  Hits        67408    67412        4     
- Misses      10683    10703       20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nathanielsimard nathanielsimard merged commit c4eac86 into main Apr 2, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the feat/add-all-choice-to-burnbench branch April 2, 2024 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants