Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move log_sigmoid to activation ops #1558

Merged
merged 1 commit into from
Apr 2, 2024
Merged

Move log_sigmoid to activation ops #1558

merged 1 commit into from
Apr 2, 2024

Conversation

laggui
Copy link
Member

@laggui laggui commented Mar 29, 2024

Checklist

  • Confirmed that run-checks all script has been executed.

Related Issues/PRs

Closes #1549

Changes

  • Moved log_sigmoid implementation to ActivationOps
  • Added log_sigmoid_backward with autodiff usage
  • Added tch backend log_sigmoid to override the default implementation

Testing

Added backward unit tests.

@laggui laggui force-pushed the fix/activation/log-sigmoid branch from e8e7c1c to 91edc22 Compare March 29, 2024 17:31
@codecov Codecov
Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 91.60305% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 86.32%. Comparing base (edcd92f) to head (91edc22).
Report is 1 commits behind head on main.

Files Patch % Lines
crates/burn-tch/src/ops/activation.rs 0.00% 10 Missing ⚠️
crates/burn-autodiff/src/ops/activation.rs 97.05% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff            @@
##             main    #1558     /-   ##
========================================
  Coverage   86.31%   86.32%            
========================================
  Files         683      684      1     
  Lines       78091    78192    101     
========================================
  Hits        67408    67499     91     
- Misses      10683    10693     10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

antimora
antimora approved these changes Mar 29, 2024
View reviewed changes
Copy link
Collaborator

@antimora antimora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nathanielsimard nathanielsimard merged commit 8d210a1 into main Apr 2, 2024
15 checks passed
@nathanielsimard nathanielsimard deleted the fix/activation/log-sigmoid branch April 2, 2024 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antimora antimora antimora approved these changes

@nathanielsimard nathanielsimard nathanielsimard approved these changes

@louisfd louisfd Awaiting requested review from louisfd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move log_sigmoid to ActivationOps
3 participants
@laggui @antimora @nathanielsimard