JIT Migration: PRNG #1433
Merged
JIT Migration: PRNG #1433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1433 /- ##
==========================================
Coverage 85.67% 85.80% 0.13%
==========================================
Files 637 640 3
Lines 70329 71145 816
==========================================
Hits 60251 61043 792
- Misses 10078 10102 24 ☔ View full report in Codecov by Sentry. |
nathanielsimard
requested changes
Mar 11, 2024
Comment on lines
383
to
397
| // It is crucial that scalars follow this order: float, int, uint | ||
| let scalar_priorities: Vec<usize> = [E1::gpu_elem(), E2::gpu_elem(), E3::gpu_elem()] | ||
| .iter() | ||
| .map(|ty: &Elem| match ty { | ||
| Elem::Float => 0, | ||
| Elem::Int => 1, | ||
| Elem::UInt => 2, | ||
| Elem::Bool => panic!("Bool scalars are not supported"), | ||
| }) | ||
| .collect(); | ||
|
|
||
| let mut handles_scalars = Vec::new(); | ||
| for i in 0..3 { | ||
| for (j, scalar_priority) in scalar_priorities.iter().enumerate() { | ||
| if scalar_priority == &i { |
There was a problem hiding this comment.
Create an array instead of a vec. We know it's 3 in length, so it's gonna be way more efficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PRNG kernels for #1422