Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/conv2d/fan #1287

Merged
merged 5 commits into from
Feb 12, 2024
Merged

Fix/conv2d/fan #1287

merged 5 commits into from
Feb 12, 2024

Conversation

louisfd
Copy link
Member

@louisfd louisfd commented Feb 10, 2024

Fix a bug introduced in #1138 where arithmetic could fail on usize type

@louisfd louisfd requested a review from laggui February 10, 2024 17:56
Copy link
Member

@laggui laggui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding the test 😎

@nathanielsimard nathanielsimard merged commit 397bc02 into main Feb 12, 2024
13 checks passed
@nathanielsimard nathanielsimard deleted the fix/conv2d/fan branch February 12, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants